test: reduce filter test runtime#1645
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1645 +/- ##
=======================================
Coverage 77.58% 77.58%
=======================================
Files 103 103
Lines 3266 3266
Branches 734 729 -5
=======================================
Hits 2534 2534
Misses 655 655
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @xbhouse , " UI/FilterTypePatch" still fails but that is because the base system which is in the Workspace called "TestSpace" is not in the results, in the table. But it is there when the test is still at the filter by operating stage of the test. |
that's expected @swadeley, the workspace filtering should be fixed once Inventory reverts the breaking changes. this PR only affects the "Filter types on Advisories page" test (reduces the runtime of that test from about 4 minutes to 1.5 minutes) and we shouldn't see timeouts like this anymore |
Description
Removes unnecessary waits from the filter test helpers. This should reduce the runtime of the "Patch Filters" > "Filter types on Advisories page" UI test.
How to test the PR
UI filter tests shouldn't time out